linux-kernel - Re: [PATCH] kernel/cpu.c: fix many errors related to style.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1494084473.31950.26.camel@perches.com>
Date:   Sat, 06 May 2017 08:27:53 -0700
From:   Joe Perches <joe@...ches.com>
To:     Matej Dujava <mdujava@...urkovo.cz>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/cpu.c: fix many errors related to style.

On Sat, 2017-05-06 at 17:09 +0200, Matej Dujava wrote:
> This patch fixes the checkpatch.pl warning:
> ERROR: spaces required around that '=' (ctx:VxW)
> WARNING: Block comments use a trailing */ on a separate line
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Blank lines aren't necessary after an open brace '{'
[]
> diff --git a/kernel/cpu.c b/kernel/cpu.c

Please don't modify core kernel files just to shut-up checkpatch
messages.  If you are doing rework, it makes some sense, otherwise
it doesn't add much value.

> -	/* Entry state on starting. Interrupts enabled from here on. Transient
> -	 * state for synchronsization */
> +	/*
> +	 * Entry state on starting. Interrupts enabled from here on. Transient
> +	 * state for synchronsization

Fixing typos would be nicer than merely reformatting comments.