linux-kernel - Re: [PATCH] staging/media/atomisp/platform/intel-mid change spaces to tabs and comma/assignment space padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 6 May 2017 05:09:52 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Gideon Sheril <elmocia@...il.com>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        rvarsha016@...il.com, julia.lawall@...6.fr, alan@...ux.intel.com,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/media/atomisp/platform/intel-mid change spaces
 to tabs and comma/assignment space padding

Subject is too long.

On Sat, May 06, 2017 at 04:04:50AM +0300, Gideon Sheril wrote:
>  /* The atomisp uses type==0 for the end-of-list marker, so leave space. */
> @@ -152,13 +152,13 @@ const struct camera_af_platform_data *camera_get_af_platform_data(void)
>  EXPORT_SYMBOL_GPL(camera_get_af_platform_data);
>  
>  int atomisp_register_i2c_module(struct v4l2_subdev *subdev,
> -                                struct camera_sensor_platform_data *plat_data,
> -                                enum intel_v4l2_subdev_type type)
> +								struct camera_sensor_platform_data *plat_data,
> +								enum intel_v4l2_subdev_type type)

Huh???

>  {
>  	int i;
>  	struct i2c_board_info *bi;
>  	struct gmin_subdev *gs;
> -        struct i2c_client *client = v4l2_get_subdevdata(subdev);
> +		struct i2c_client *client = v4l2_get_subdevdata(subdev);


Wut?  How would this be correct?

regards,
dan carpenter