Message-ID: <CAFXWsS8+bojRKd6Kz-rzq36bikOTdYX+f+cjkN-Jaiak8uxVmA@mail.gmail.com>
Date:   Sat, 6 May 2017 18:00:24 +1000
From:   Ian W MORRISON <ianwmorrison@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        devel@...uxdriverproject.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

On 6 May 2017 at 07:56, Greg KH <gregkh@...uxfoundation.org> wrote:
> Note:  There will be a merge conflict when you pull this into your tree
> in drivers/staging/Kconfig.  Sorry about that, it was a stupid mistake
> on my part when I added a new driver to staging from the USB tree and I
> tried to do it without a merge conflict, but missed that I actually
> added one.  It is trivial to resolve.
>
> But, when you merge this tree you will get build errors in the new wifi
> driver due to api changes that are coming in through the network tree.
> I have a set of 3 patches from Stephen Rothwell that will fix those
> issues.  I'll reply to this email with those patches, if you want to
> apply them after you do the merge, then 0-day will be happy.
>
> Or I can send you a follow-on pull request after you do the merge with
> those 3 patches applied, it's your choice, which ever is easier for you.
>
> I figured both of these are better than doing the merge myself and
> "hiding" the api change fixes in the merge commit.  It's a crazy staging
> wifi driver, not anything that most people care about :)
>
> thanks,
>
> greg k-h
>
> -----------------------
>

<snip>

Hi Greg,

A kernel cloned from
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and
built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m)
still fails when booting on an Intel Atom device with the RTL8723BS
wifi chipset due to the bug in
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

For example 'dmesg' shows:

[    6.170488] r8723bs: module is from the staging directory, the
quality is unknown, you have been warned.
[    6.206741] RTL8723BS: rtw_ndev_init(wlan0)
[    6.206836] ------------[ cut here ]------------
[    6.206840] kernel BUG at net/wireless/core.h:111!
[    6.206928] invalid opcode: 0000 [#1] SMP
[    6.206984] Modules linked in: snd_soc_core(+) snd_compress
snd_pcm_dmaengine snd_hdmi_lpe_audio ac97_bus snd_pcm snd_seq_midi
snd_seq_midi_event snd_rawmidi hci_uart mac_hid btbcm r8723bs(C+)
serdev btqca snd_seq btintel bluetooth snd_seq_device snd_timer
cfg80211 dw_dmac dw_dmac_core soc_button_array ecdh_generic snd
rfkill_gpio soundcore mei_txe acpi_pad spi_pxa2xx_platform
pwm_lpss_platform i2c_designware_platform(+) pwm_lpss
i2c_designware_core mei lpc_ich 8250_dw parport_pc ppdev lp parport
ip_tables x_tables autofs4 hid_logitech_hidpp hid_logitech_dj
hid_generic usbhid i915 mmc_block i2c_algo_bit drm_kms_helper
syscopyarea sysfillrect sysimgblt fb_sys_fops drm video i2c_hid hid
sdhci_acpi sdhci
[    6.207802] CPU: 0 PID: 341 Comm: systemd-udevd Tainted: G
C      4.11.0-linuxium #1
[    6.207908] Hardware name: Intel Corporation
STCK1A32WFC/STCK1A32WFC, BIOS FCBYT10H.86A.0032.2016.0831.1658
08/31/2016
[    6.208041] task: ffff90c2ef0c0000 task.stack: ffffa1b2c0910000
[    6.208161] RIP: 0010:cfg80211_netdev_notifier_call+0x4a8/0x620 [cfg80211]
[    6.208249] RSP: 0000:ffffa1b2c0913908 EFLAGS: 00010246
[    6.208319] RAX: 0000000000000000 RBX: ffff90c2b4750000 RCX: 0000000000000000
[    6.208410] RDX: ffffa1b2c0913a78 RSI: 0000000000000010 RDI: ffffffffc065c200
[    6.208501] RBP: ffffa1b2c09139f8 R08: 0000000000000000 R09: ffffffffc065c200
[    6.208591] R10: ffffa1b2c0913a08 R11: ffffa1b2c0913918 R12: 0000000000000000
[    6.208682] R13: ffff90c2f9471000 R14: ffffa1b2c0913a78 R15: 0000000000000000
[    6.208774] FS:  00007fe662ef98c0(0000) GS:ffff90c2f9e00000(0000)
knlGS:0000000000000000
[    6.208876] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    6.208950] CR2: 000055d3daac8010 CR3: 0000000073fb4000 CR4: 00000000001006f0

or when the RTL8723BS firmware is installed 'dmesg' shows:

[    6.520902] RTL8723BS: rtw_ndev_init(wlan0)
[    6.521420] general protection fault: 0000 [#1] SMP
[    6.521508] Modules linked in: intel_cstate(+) joydev input_leds
cdc_ether usbnet r8152 mii hci_uart bmc150_accel_spi btbcm
bmc150_accel_i2c snd_soc_rt5670 bmc150_accel_core serdev
industrialio_triggered_buffer btqca kfifo_buf snd_soc_rt5645
axp20x_i2c btintel industrialio axp20x snd_soc_rt5640
snd_intel_sst_acpi bluetooth snd_soc_tlv320aic31xx snd_soc_rl6231
snd_intel_sst_core snd_soc_sst_atom_hifi2_platform snd_soc_sst_match
r8723bs(C+) ecdh_generic cfg80211 rfkill_gpio snd_hdmi_lpe_audio
snd_soc_core lpc_ich snd_compress snd_pcm_dmaengine ac97_bus snd_pcm
mei_txe snd_seq_midi mei snd_seq_midi_event snd_rawmidi snd_seq
snd_seq_device mac_hid snd_timer snd soc_button_array dw_dmac
dw_dmac_core soundcore 8250_dw pwm_lpss_platform acpi_pad pwm_lpss
i2c_designware_platform spi_pxa2xx_platform i2c_designware_core
[    6.522443]  parport_pc ppdev lp parport ip_tables x_tables autofs4
hid_logitech_hidpp hid_logitech_dj hid_generic usbhid i915 mmc_block
i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt
fb_sys_fops drm video i2c_hid hid sdhci_acpi sdhci
[    6.522744] CPU: 0 PID: 318 Comm: systemd-udevd Tainted: G
C      4.11.0-linuxium #1
[    6.522851] Hardware name: Intel Corporation
STCK1A32WFC/STCK1A32WFC, BIOS FCBYT10H.86A.0032.2016.0831.1658
08/31/2016
[    6.522986] task: ffff9e81af1f5500 task.stack: ffffb8d900898000
[    6.523109] RIP: 0010:cfg80211_netdev_notifier_call+0x256/0x620 [cfg80211]
[    6.523200] RSP: 0000:ffffb8d90089b908 EFLAGS: 00010202
[    6.523271] RAX: 000000006332692f RBX: ffff9e81bab6ec00 RCX: 0000000073656369
[    6.523362] RDX: ffffffffc0805a8c RSI: ffffffffc07e85c8 RDI: ffff9e81bab6ec48
[    6.523452] RBP: ffffb8d90089b9f8 R08: ffff9e81b9e1e560 R09: ffffffffc07f4200
[    6.523541] R10: ffffb8d90089ba08 R11: ffff9e81b1e05a00 R12: 7665642f40646461
[    6.523631] R13: ffff9e81b291e000 R14: 7665642f40646161 R15: 0000000000000000
[    6.523721] FS:  00007fbfa0f268c0(0000) GS:ffff9e81b9e00000(0000)
knlGS:0000000000000000
[    6.523824] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    6.523898] CR2: 000055d1f6295f88 CR3: 00000000705de000 CR4: 00000000001006f0

The kernel when booted with Ubuntu 17.04 results in an unusable system
however with the following patch booting is successful and the system
is usable. The patch and kernel builds have been tested against on an
Intel Compute Stick (STCK1A32WFC model).

Regards,
Ian

From: Ian W Morrison <linuxium@...uxium.com.au>
Date: Fri, 28 Apr 2017 02:20:38 +1000
Subject: [PATCH] staging: rtl8723bs: remove a call to kfree in
 os_dep/ioctl_cfg80211.c

Signed-off-by: Ian W Morrison <linuxium@...uxium.com.au>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter,
struct device *dev)
                pwdev_priv->power_mgmt = true;
        else
                pwdev_priv->power_mgmt = false;
-       kfree((u8 *)wdev);

        return ret;

--
1.9.1

Powered by blists - more mailing lists