linux-kernel - Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170506084004.awyhl2w2b2qnbvt2@mwanda>
Date:   Sat, 6 May 2017 11:40:04 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        thierry.escande@...labora.com, wnhuang@...gle.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: Google VPD: Fix memory allocation error
 handling

On Fri, May 05, 2017 at 12:56:47PM -0700, Greg KH wrote:
> On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> > This patch fixes several issues:
> >    - if the 1st 'kzalloc' fails, we dereference a NULL pointer
> >    - if the 2nd 'kzalloc' fails, there is a memory leak
> >    - if 'sysfs_create_bin_file' fails there is also a memory leak
> 
> Then it should be multiple patches, not fixing 3 things in one patch,
> right?
> 

I agree with Christophe that this is basically one thing.  Otherwise you
end up breaking it up how Elfring does it into tiny tiny snippets that I
can't read.  Doing it this way is easier to review for me.

regards,
dan carpenter