linux-kernel - Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1494063147.22420.57.camel@hadess.net>
Date:   Sat, 06 May 2017 11:32:27 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Justin Vreeland <justin@...eeland.com>, gregkh@...uxfoundation.org,
        Larry.Finger@...inger.net
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as
 conditional

On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote:
> 
<snip>
> Sorry about blank email.
> 
> I'm not 100% happy with it either.  Larry Finger suggested to fix the
> overly long lines so I tried to find a decent way to shorten them.  I
> think the best way would be to change the function names or pull the
> function
> calls out of the if statements.
> 
> If these line breaks aren't a good solution and keeping them over 80
> isn't either I'd
> rather drop this patch from the set if that's okay.

Dropping the sections of this patch that require linefeeds in the
middle of if statements would be fine by me. I don't think that a brace
on the next line is worse than splitting a condition on 2 lines.

Cheers