linux-kernel - Re: [PATCH] char: random: casting prevents missing calculations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a08NW6FYOMh1veO7qy2=1q-naXRhNbqf=X7FZePsMz4cw@mail.gmail.com>
Date:   Sun, 7 May 2017 20:36:55 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Karim Eshapa <karim.eshapa@...il.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        gregkh <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] char: random: casting prevents missing calculations

On Sun, May 7, 2017 at 2:47 PM, Karim Eshapa <karim.eshapa@...il.com> wrote:
> Cast (long)jiffies and (long)state->last_time beacause
> they tends to unsigned long. may cause a problem specially
> when comparison happens (< 0).
>
> Signed-off-by: Karim Eshapa <karim.eshapa@...il.com>

I don't understand what you are saying above, and the patch does not
appear to have any effect since the destination variable is already of
type 'long'.

What problem did you observe?

       Arnd