linux-kernel - [PATCH v4] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 May 2017 14:01:39 +1000
From:   Ian W MORRISON <ianwmorrison@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org, hadess@...ess.net,
        Larry.Finger@...inger.net, hdegoede@...hat.com,
        jes.sorensen@...il.com, kvalo@....qualcomm.com
Subject: [PATCH v4] staging: rtl8723bs: remove re-positioned call to kfree in
 os_dep/ioctl_cfg80211.c

A kernel cloned from 
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and 
built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) 
fails when booting on an Intel Atom device with the RTL8723BS wifi 
chipset due to an error in 
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c.

The kernel when booted with Ubuntu 17.04 results in an unusable system 
however with the following patch booting is successful and the system 
is usable. The patch and kernel builds have been tested against on an 
Intel Compute Stick (STCK1A32WFC model).

This version of the patch (version 4) has tabs rather than spaces, no 
wrap around and a changelog. The patch has received one review:

Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Signed-off-by: Ian W Morrison <linuxium@...uxium.com.au>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct device *dev)
 		pwdev_priv->power_mgmt = true;
 	else
 		pwdev_priv->power_mgmt = false;
-	kfree((u8 *)wdev);

 	return ret;

-- 
1.9.1