linux-kernel - [PATCH] android: binder: Use seq_putc() in print_binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 7 May 2017 22:15:37 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     devel@...verdev.osuosl.org,
        Arve Hjønnevåg <arve@...roid.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Riley Andrews <riandrews@...roid.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH] android: binder: Use seq_putc() in print_binder_node()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sun, 7 May 2017 22:07:16 +0200

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index aae4d8d4be36..041b49b0bbd9 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3871,7 +3871,7 @@ static void print_binder_node(struct seq_file *m, struct binder_node *node)
 		hlist_for_each_entry(ref, &node->refs, node_entry)
 			seq_printf(m, " %d", ref->proc->pid);
 	}
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
 	list_for_each_entry(w, &node->async_todo, entry)
 		print_binder_work(m, "    ",
 				  "    pending async transaction", w);
-- 
2.12.2