linux-kernel - Re: [PATCH] perf, tools: Support srccode output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170507152917.GG27157@tassilo.jf.intel.com>
Date:   Sun, 7 May 2017 08:29:17 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
        jolsa@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf, tools: Support srccode output

> so get_srcline formats srcline and you parse it out back in here,
> I think it'd be better to factor __get_srcline and get the file
> and line directly

It's not true for the addr2line fallback which gets the already formatted 
string. So at some point it would need to be parsed.

But ok I can move it into the low level function. It just makes the patch
more complicated.

-Andi