linux-kernel - Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 May 2017 09:56:40 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions

On Sun, May 7, 2017 at 9:53 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> With gcc 4.1.2:
>
>     drivers/staging/ccree/ssi_hash.c:1990: error: unknown field ‘template_ahash’ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1991: error: unknown field ‘init’ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1991: warning: missing braces around initializer
>     drivers/staging/ccree/ssi_hash.c:1991: warning: (near initialization for ‘driver_hash[0].<anonymous>.template_ahash’)
>     drivers/staging/ccree/ssi_hash.c:1992: error: unknown field ‘update’ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1992: warning: excess elements in union initializer
>     ...
>
> Add missing braces to fix this.
> After this it compiles without warnings with gcc 4.1.2 and 4.9.0.

Acked-by: Arnd Bergmann <arnd@...db.de>

For reference, we need this up to gcc-4.5, the anonymous initializers were added
on gcc-4.6.

     Arnd