linux-kernel - Re: [PATCH] lightnvm: remove unused rq parameter of nvme_nvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bc0bd5f-4eb5-5975-4700-071b78047917@fb.com>
Date:   Sun, 7 May 2017 19:53:33 -0600
From:   Jens Axboe <axboe@...com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Javier González <javier@...xlabs.com>,
        Matias Bjørling <matias@...xlabs.com>,
        Keith Busch <keith.busch@...el.com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>
CC:     <linux-nvme@...ts.infradead.org>, Arnd Bergmann <arnd@...db.de>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lightnvm: remove unused rq parameter of
 nvme_nvm_rqtocmd() to kill warning

On 05/07/2017 08:14 AM, Geert Uytterhoeven wrote:
> With gcc 4.1.2:

Wow, that's ancient.

>     drivers/nvme/host/lightnvm.c: In function ‘nvme_nvm_submit_io’:
>     drivers/nvme/host/lightnvm.c:498: warning: ‘rq’ is used uninitialized in this function
> 
> Indeed, since commit 2e13f33a2464fc3a ("lightnvm: create cmd before
> allocating request"), the request is passed to nvme_nvm_rqtocmd() before
> it is allocated.
> 
> Fortunately, as of commit 91276162de9476b8 ("lightnvm: refactor end_io
> functions for sync"), nvme_nvm_rqtocmd () no longer uses the passed
> request, so this warning is a false positive.
> 
> Drop the unused parameter to clean up the code and kill the warning.

Thanks, applied.

-- 
Jens Axboe