linux-kernel - Re: [RFC PATCH 0/3] clk: introduce clk_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170508110726.GA18153@b29396-OptiPlex-7040>
Date:   Mon, 8 May 2017 19:07:26 +0800
From:   Dong Aisheng <dongas86@...il.com>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Dong Aisheng <aisheng.dong@....com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        kernel@...gutronix.de, broonie@...nel.org, yibin.gong@....com,
        rjw@...ysocki.net, viresh.kumar@...aro.org,
        mturquette@...libre.com, shawnguo@...nel.org,
        fabio.estevam@....com, anson.huang@....com, ping.bai@....com,
        leonard.crestez@....com, octavian.purdila@....com
Subject: Re: [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories

On Fri, Apr 21, 2017 at 08:04:19PM -0700, Stephen Boyd wrote:
> On 04/12, Dong Aisheng wrote:
> > 
> > Together with the err path handling for each clocks, it does make
> > things a bit ugly.
> > 
> > Since we already have regulator_bulk_get accessories, i thought we
> > probably could introduce clk_bulk_get as well to handle such case to
> > ease the driver owners' life. 
> > 
> > Besides IMX cpufreq driver, there is also some similar cases
> > in kernel which could befinit from this api as well.
> > e.g.
> > drivers/cpufreq/tegra124-cpufreq.c
> > drivers/cpufreq/s3c2412-cpufreq.c
> > sound/soc/samsung/smdk_spdif.c
> > arch/arm/mach-omap1/serial.c
> > ...
> > 
> > And actually, if we handle clocks more than 3, then it might be
> > worthy to try, which there is quite many manay in kernel and
> > that probably could save a lot codes.
> > 
> > This is a RFC patch intending to bring up the idea to discuss.
> > 
> 
> Idea seems fine to me. Please also add Russell King, as we need
> an ack from him on the clk.h API changes.
> 

Great! Thanks! And sorry to miss Russell King.
Quite willing to add him to help review in the next series.

Regards
Dong Aisheng