linux-kernel - [PATCH 2/2] drm/etnaviv: Delete an error message for a failed memory allocation in etnaviv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <782e850b-0376-c641-8ede-7b9ed6d385b9@users.sourceforge.net>
Date:   Mon, 8 May 2017 13:22:30 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Lucas Stach <l.stach@...gutronix.de>,
        Russell King <linux+etnaviv@...linux.org.uk>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>
Subject: [PATCH 2/2] drm/etnaviv: Delete an error message for a failed memory
 allocation in etnaviv_bind()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 8 May 2017 13:08:11 +0200

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such a statement here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index b4deb26e1e40..b121473622d0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -530,7 +530,6 @@ static int etnaviv_bind(struct device *dev)
 
 	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
 	if (!priv) {
-		dev_err(dev, "failed to allocate private data\n");
 		ret = -ENOMEM;
 		goto out_unref;
 	}
-- 
2.12.2