lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 May 2017 13:30:52 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Masami Hiramatsu <mhiramat@...nel.org> Cc: SeongJae Park <sj38.park@...il.com>, Peter Zijlstra <peterz@...radead.org>, Taeung Song <treeze.taeung@...il.com>, Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] perf probe: Fix examples section of documentation Em Tue, May 09, 2017 at 12:19:57AM +0900, Masami Hiramatsu escreveu: > On Sun, 7 May 2017 19:36:42 +0900 > SeongJae Park <sj38.park@...il.com> wrote: > > > An example in perf-probe documentation for pattern of function name > > based probe addition is not providing example command for the case. > > This commit fixes the example to give appropriate example command. > > > > Signed-off-by: SeongJae Park <sj38.park@...il.com> > > Good catch! > > Acked-by: Masami Hiramatsu <mhiramat@...nel.org> Thanks, I added the suggested Fixes: tag, - Arnaldo > Thank you! > > > --- > > tools/perf/Documentation/perf-probe.txt | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt > > index e6c9902c6d82..165c2b1d4317 100644 > > --- a/tools/perf/Documentation/perf-probe.txt > > +++ b/tools/perf/Documentation/perf-probe.txt > > @@ -240,9 +240,13 @@ Add a probe on schedule() function 12th line with recording cpu local variable: > > or > > ./perf probe --add='schedule:12 cpu' > > > > - this will add one or more probes which has the name start with "schedule". > > +Add one or more probes which has the name start with "schedule". > > > > - Add probes on lines in schedule() function which calls update_rq_clock(). > > + ./perf probe schedule* > > + or > > + ./perf probe --add='schedule*' > > + > > +Add probes on lines in schedule() function which calls update_rq_clock(). > > > > ./perf probe 'schedule;update_rq_clock*' > > or > > -- > > 2.12.0 > > > > > -- > Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists