linux-kernel - Re: [PATCH v2 3/4] perf config: Correctly check whether it is from system config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170508163952.GJ7891@kernel.org>
Date:   Mon, 8 May 2017 13:39:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Taeung Song <treeze.taeung@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v2 3/4] perf config: Correctly check whether it is from
 system config

Em Mon, May 08, 2017 at 08:07:45PM +0900, Taeung Song escreveu:
> Currently section's from_system_config was checked twice.

 you mean:

"The item->from_system_config is not being checked when iterating over
 section->items, instead section->from_system_config is being checked
 multiple times, fix this"

?

> So adjust it in order to correctly check not only section's
> but also item's from_system_config.
> 
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Taeung Song <treeze.taeung@...il.com>
> ---
>  tools/perf/builtin-config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
> index 0d38599..2a6ca0d 100644
> --- a/tools/perf/builtin-config.c
> +++ b/tools/perf/builtin-config.c
> @@ -56,7 +56,7 @@ static int set_config(struct perf_config_set *set, const char *file_name)
>  		fprintf(fp, "[%s]\n", section->name);
>  
>  		perf_config_items__for_each_entry(&section->items, item) {
> -			if (!use_system_config && section->from_system_config)
> +			if (!use_system_config && item->from_system_config)
>  				continue;
>  			if (item->value)
>  				fprintf(fp, "\t%s = %s\n",
> -- 
> 2.7.4