linux-kernel - Re: [PATCH] dt-bindings: power: New bindings for ltc3651-charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170508171206.ajxjbw5mybvrpwss@rob-hp-laptop>
Date:   Mon, 8 May 2017 12:12:06 -0500
From:   Rob Herring <robh@...nel.org>
To:     Mike Looijmans <mike.looijmans@...ic.nl>
Cc:     devicetree@...r.kernel.org, sre@...nel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        mark.rutland@....com
Subject: Re: [PATCH] dt-bindings: power: New bindings for ltc3651-charger

On Fri, May 05, 2017 at 08:38:35AM +0200, Mike Looijmans wrote:
> This adds the devicetree bindings documentation for the LTC3651 battery charger.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---
>  .../bindings/power/supply/ltc3651-charger.txt      | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> new file mode 100644
> index 0000000..a7dd80f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/ltc3651-charger.txt
> @@ -0,0 +1,26 @@
> +ltc3651-charger
> +
> +Required properties:
> + - compatible: "lltc,ltc3651-charger"
> + - acpr-gpios: Connect to ACPR output. See remark below.
> +
> +Optional properties:
> + - fault-gpios: Connect to FAULT output. See remark below.
> + - chrg-gpios: Connect to CHRG output. See remark below.

All the gpios need vendor prefix.

> +
> +The ltc3651 outputs are open-drain type and active low. The driver assumes the
> +GPIO reports "active" when the output is asserted, so if the pins have been
> +connected directly, the GPIO flags should be set to active low also.
> +
> +The driver will attempt to aquire interrupts for all GPIOs. If the system is
> +not capabale of providing that, the driver cannot report changes and userspace
> +will need to periodically read the sysfs attributes to detect changes.

If these are interrupts, then you should use the interrupt binding 
instead (most GPIO controllers are also interrupt controllers).

> +
> +Example:
> +
> +	charger: battery-charger {
> +		compatible = "lltc,ltc3651-charger";
> +		acpr-gpios = <&gpio0 68 GPIO_ACTIVE_LOW>;
> +		fault-gpios = <&gpio0 64 GPIO_ACTIVE_LOW>;
> +		chrg-gpios = <&gpio0 63 GPIO_ACTIVE_LOW>;
> +	};
> -- 
> 1.9.1
>