linux-kernel - Re: [PATCH] powerpc: fix distclean with Makefile.postlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFxkdAqCdY6g2Gb7rC_A+tgqSZj1ey9rPV9UrXMBq92BR_eSYg@mail.gmail.com>
Date:   Mon, 8 May 2017 16:35:45 -0500
From:   Justin Forbes <jmforbes@...uxtx.org>
To:     Horia Geantă <horia.geanta@....com>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Mircea Pop <mircea.pop@....com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc: fix distclean with Makefile.postlink

On Mon, May 8, 2017 at 8:50 AM, Horia Geantă <horia.geanta@....com> wrote:
> On 5/8/2017 2:57 PM, Michael Ellerman wrote:
>> Horia Geantă <horia.geanta@....com> writes:
>>
>>> Makefile.postlink always includes include/config/auto.conf, however
>>> this file is not present in a clean kernel tree, causing make to fail:
>>>
>>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
>>> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
>>> make: *** [vmlinuxclean] Error 2
>>>
>>> Change the inclusion such that file not being found does not trigger
>>> an error.
>>>
>>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
>>
>> I can't reproduce this. What exact steps are you doing? And what version
>> of Make?
>>
> Start with a clean kernel tree and then
> make distclean
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
> file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
> make: *** [vmlinuxclean] Error 2
>
> make --version
> GNU Make 3.82
> Built for x86_64-redhat-linux-gnu
> Copyright (C) 2010  Free Software Foundation, Inc.
> [...]
>
> The fix is basically the same as:
> 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
>

Noticed it on the Fedora builds as well today.  This patch fixes it.

Tested-by: Justin M. Forbes <jforbes@...oraproject.org>