linux-kernel - Re: [PATCH] x86/mm: Set __vmalloc_start_set in numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+E9AGn8SosiBv921gt0Te-Xh4cTr4XYh0MD-jueDnorw@mail.gmail.com>
Date:   Mon, 8 May 2017 15:28:42 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/mm: Set __vmalloc_start_set in numa_32.c

On Mon, May 8, 2017 at 2:23 PM, Laura Abbott <labbott@...hat.com> wrote:
> __vmalloc_start_set currently only gets set in initmem_init when
> !CONFIG_NEED_MULTIPLE_NODES. This currently breaks detection of vmalloc
> address with virt_addr_valid with CONFIG_NEED_MULTIPLE_NODES=y.
> Set __vmalloc_start_set appropriately for that case as well.
>
> Fixes: dc16ecf7fd1f ("x86-32: use specific __vmalloc_start_set flag in __virt_addr_valid")q

Nit: trailing "q" typo

> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Laura Abbott <labbott@...hat.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

Thanks for tracking this down!

-Kees

> ---
>  arch/x86/mm/numa_32.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c
> index 6b7ce62..aca6295 100644
> --- a/arch/x86/mm/numa_32.c
> +++ b/arch/x86/mm/numa_32.c
> @@ -100,5 +100,6 @@ void __init initmem_init(void)
>         printk(KERN_DEBUG "High memory starts at vaddr %08lx\n",
>                         (ulong) pfn_to_kaddr(highstart_pfn));
>
> +       __vmalloc_start_set = true;
>         setup_bootmem_allocator();
>  }
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security