linux-kernel - Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170509064504.7zwre5ffl56twvoi@hirez.programming.kicks-ass.net>
Date:   Tue, 9 May 2017 08:45:04 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Konstantin Khlebnikov <koct9i@...il.com>
Cc:     Daniel Axtens <dja@...ens.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Konstantin Khlebnikov <khlebnikov@...dex-team.ru>,
        Ben Segall <bsegall@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq

On Mon, May 08, 2017 at 10:32:30PM +0300, Konstantin Khlebnikov wrote:
> On Mon, May 8, 2017 at 10:22 PM, Daniel Axtens <dja@...ens.net> wrote:

> > I recently had to debug a problem with these (we hadn't backported
> > Konstantin's patches in this area) and this would have saved a lot
> > of time/pain.
> 
> Yep, this is worth debug. But I think it should be under compile-time
> config option.
> Something like CONFIG_DEBUG_VM which enables VM_BUG_ON and VM_WARN_ON.

See SCHED_WARN_ON() and feel free to introduce SCHED_WARN_ON_ONCE() if
you feel that's needed.