lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 May 2017 09:11:24 +0100 From: David Howells <dhowells@...hat.com> To: Kees Cook <keescook@...omium.org> Cc: dhowells@...hat.com, James Morris <james.l.morris@...cle.com>, "Serge E. Hallyn" <serge@...lyn.com>, keyrings@...r.kernel.org, linux-security-module <linux-security-module@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] key: Convert big_key payload.data to struct Kees Cook <keescook@...omium.org> wrote: > This doesn't protect you against changes in struct path size, > though... the existing code (and this proposal) will break if that > ever happens... True - in which case you should kmalloc() it as Eric suggests. > What's the problem with defining the types at the top level? That > seems like a nice place to see them all at once. It means adding a bunch of dependencies to linux/key.h and union key_payload. Have you considered why we don't just put all the definitions for all the filesystems in linux/fs.h? By this logic it would seem like a nice place to see them all at once. David
Powered by blists - more mailing lists