linux-kernel - Re: [PATCH v2] Input: elan_i2c - check if device is there before really probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BjGVU3N1YZVo9JiTaKzWcvq1GA_dskXtA4LvNGKG8kNw@mail.gmail.com>
Date:   Mon, 8 May 2017 22:43:36 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, KT Liao <ktalex.liao@...il.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Input: elan_i2c - check if device is there before
 really probing

On Mon, May 8, 2017 at 9:45 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:

> +       /* Make sure there is something at this address */
> +       error = i2c_smbus_read_byte(client);
> +       if (error < 0) {
> +               dev_dbg(&client->dev, "nothing at this address: %d\n", error);
> +               return -ENXIO;

You could return the real error code here: 'return error'