linux-kernel - Re: [PATCH] gpu: drm: amd: amdgpu: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 9 May 2017 13:27:34 +0200
From:   Christian König <christian.koenig@....com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>,
        Tom St Denis <tom.stdenis@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Monk Liu <Monk.Liu@....com>, Huang Rui <ray.huang@....com>
CC:     <amd-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>,
        Peter Senna Tschudin <peter.senna@...il.com>
Subject: Re: [PATCH] gpu: drm: amd: amdgpu: remove dead code

Am 08.05.2017 um 18:41 schrieb Gustavo A. R. Silva:
> Local variable use_doorbell is assigned to a constant value and it is never
> updated again. Remove this variable and the dead code it guards.
>
> Addresses-Coverity-ID: 1401837
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Acked-by: Christian König <christian.koenig@....com> for this one and 
the same patch for gfx_v8.

> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 20 ++++++--------------
>   1 file changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> index 1f93545..27ea28f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c
> @@ -2936,7 +2936,6 @@ static int gfx_v7_0_cp_compute_resume(struct amdgpu_device *adev)
>   {
>   	int r, i, j;
>   	u32 tmp;
> -	bool use_doorbell = true;
>   	u64 hqd_gpu_addr;
>   	u64 mqd_gpu_addr;
>   	u64 eop_gpu_addr;
> @@ -3034,10 +3033,7 @@ static int gfx_v7_0_cp_compute_resume(struct amdgpu_device *adev)
>   		/* enable doorbell? */
>   		mqd->queue_state.cp_hqd_pq_doorbell_control =
>   			RREG32(mmCP_HQD_PQ_DOORBELL_CONTROL);
> -		if (use_doorbell)
> -			mqd->queue_state.cp_hqd_pq_doorbell_control |= CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK;
> -		else
> -			mqd->queue_state.cp_hqd_pq_doorbell_control &= ~CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK;
> +		mqd->queue_state.cp_hqd_pq_doorbell_control |= CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK;
>   		WREG32(mmCP_HQD_PQ_DOORBELL_CONTROL,
>   		       mqd->queue_state.cp_hqd_pq_doorbell_control);
>   
> @@ -3116,23 +3112,19 @@ static int gfx_v7_0_cp_compute_resume(struct amdgpu_device *adev)
>   		       mqd->queue_state.cp_hqd_pq_rptr_report_addr_hi);
>   
>   		/* enable the doorbell if requested */
> -		if (use_doorbell) {
> -			mqd->queue_state.cp_hqd_pq_doorbell_control =
> +		mqd->queue_state.cp_hqd_pq_doorbell_control =
>   				RREG32(mmCP_HQD_PQ_DOORBELL_CONTROL);
> -			mqd->queue_state.cp_hqd_pq_doorbell_control &=
> +		mqd->queue_state.cp_hqd_pq_doorbell_control &=
>   				~CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_OFFSET_MASK;
> -			mqd->queue_state.cp_hqd_pq_doorbell_control |=
> +		mqd->queue_state.cp_hqd_pq_doorbell_control |=
>   				(ring->doorbell_index <<
>   				 CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_OFFSET__SHIFT);
> -			mqd->queue_state.cp_hqd_pq_doorbell_control |=
> +		mqd->queue_state.cp_hqd_pq_doorbell_control |=
>   				CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_EN_MASK;
> -			mqd->queue_state.cp_hqd_pq_doorbell_control &=
> +		mqd->queue_state.cp_hqd_pq_doorbell_control &=
>   				~(CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_SOURCE_MASK |
>   				CP_HQD_PQ_DOORBELL_CONTROL__DOORBELL_HIT_MASK);
>   
> -		} else {
> -			mqd->queue_state.cp_hqd_pq_doorbell_control = 0;
> -		}
>   		WREG32(mmCP_HQD_PQ_DOORBELL_CONTROL,
>   		       mqd->queue_state.cp_hqd_pq_doorbell_control);
>