linux-kernel - Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170509022101.GA2562@tetsubishi>
Date:   Tue, 9 May 2017 04:21:01 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Joel Stanley <joel@....id.au>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Kachalov Anton <mouse@...c.ru>,
        Cédric Le Goater <clg@...d.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Ryan Chen <ryan_chen@...eedtech.com>
Subject: Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C


> > +              /* TODO: provide device tree option for multi-master mode.
> > */
> 
> 
> I am curious what everyone thinks about this. It seemed that, earlier on,
> people did not like me disabling multi-master mode, but I think that it
> would make bus recovery not work as well. Given that, I think it makes the
> most sense to provide a device tree option either to enable multi-master
> support or disable it. Thoughts?

Check Documentation/devicetree/bindings/i2c/i2c.txt, there is a
"multi-master" property already which I think you could use here.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)