linux-kernel - Re: [PATCH] staging: typec: Make undeclared symbol static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170509160441.GA14061@roeck-us.net>
Date:   Tue, 9 May 2017 09:04:41 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Guru Das Srinagesh <gurooodas@...il.com>
Cc:     groeck@...omium.org, gregkh@...uxfoundation.org,
        heikki.krogerus@...ux.intel.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: typec: Make undeclared symbol static

On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote:
> Fix sparse warning:
>   drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
>   was not declared. Should it be static?
> 
> Signed-off-by: Guru Das Srinagesh <gurooodas@...il.com>

Olivier Leveque already sent a similar patch last week.

Thanks,
Guenter

> ---
>  drivers/staging/typec/tcpci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index 5e5be74..df72d8b 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
>  	.max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
>  };
>  
> -const struct tcpc_config tcpci_tcpc_config = {
> +static const struct tcpc_config tcpci_tcpc_config = {
>  	.type = TYPEC_PORT_DFP,
>  	.default_role = TYPEC_SINK,
>  };
> -- 
> 2.7.4
>