lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 May 2017 23:10:55 +0200 From: Michal Hocko <mhocko@...nel.org> To: linux-kernel@...r.kernel.org Cc: akpm@...ux-foundation.org, mm-commits@...r.kernel.org Subject: Re: + mm-vmalloc-fix-vmalloc-users-tracking-properly-checkpatch-fixes.patch added to -mm tree On Tue 09-05-17 13:34:39, Andrew Morton wrote: > From: Andrew Morton <akpm@...ux-foundation.org> > Subject: mm-vmalloc-fix-vmalloc-users-tracking-properly-checkpatch-fixes > > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' > #4: > 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users") has pulled > > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #12: > >> arch/m68k/include/asm/mcf_pgtable.h:339:43: error: 'init_mm' undeclared (first use in this function) > > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' > #36: > This patch reverts 1f5307b1e094 and reimplements the original fix in a > > WARNING: line over 80 characters > #71: FILE: include/linux/vmalloc.h:85: > +static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void* caller) > > ERROR: "foo* bar" should be "foo *bar" > #71: FILE: include/linux/vmalloc.h:85: > +static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void* caller) > > ERROR: "foo* bar" should be "foo *bar" > #92: FILE: include/linux/vmalloc.h:96: > + int node, gfp_t flags, void* caller); > > WARNING: line over 80 characters > #143: FILE: mm/vmalloc.c:1820: > +void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void *caller) > > total: 4 errors, 3 warnings, 80 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/mm-vmalloc-fix-vmalloc-users-tracking-properly.patch has style problems, please review. Thanks for the fixups Andrew! While you are at it I've noticed that I forgot to revert the comment for the originally inlined __vmalloc_node_flags which is no longer relevant. Could to fold this as well please? --- diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h index 268b3a919a5f..0e8e125b1ed6 100644 --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -87,11 +87,6 @@ static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, gf return __vmalloc_node_flags(size, node, flags); } #else -/* - * We really want to have this inlined due to caller tracking. This - * function is used by the highlevel vmalloc apis and so we want to track - * their callers and inlining will achieve that. - */ extern void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void* caller); #endif -- Michal Hocko SUSE Labs
Powered by blists - more mailing lists