linux-kernel - Re: [PATCH] x86/power/64: Use char arrays for asm function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170510054922.y6pds2gexwt6fked@gmail.com>
Date:   Wed, 10 May 2017 07:49:22 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-pm@...r.kernel.org, Daniel Micay <danielmicay@...il.com>
Subject: Re: [PATCH] x86/power/64: Use char arrays for asm function names


* Rafael J. Wysocki <rjw@...ysocki.net> wrote:

> On Tuesday, May 09, 2017 02:00:51 PM Kees Cook wrote:
> > This switches the hibernate_64.S function names into character arrays
> > to match other areas of the kernel where this is done (e.g., linker
> > scripts). Specifically this fixes a compile-time error noticed by the
> > future CONFIG_FORTIFY_SOURCE routines that complained about PAGE_SIZE
> > being copied out of the "single byte" core_restore_code variable.
> > 
> > Additionally drops the "acpi_save_state_mem" exern which does not
> > appear to be used anywhere else in the kernel.
> > 
> > Cc: Daniel Micay <danielmicay@...il.com>
> > Signed-off-by: Kees Cook <keescook@...omium.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Or I can queue this up if that's preferred.

LGTM too!

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo