linux-kernel - Re: [PATCH v2] iio:ad5064: Add support for ltc2633 and similar devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c29df10c-8715-363e-02f4-e3231b65ad51@metafoo.de>
Date:   Wed, 10 May 2017 11:12:00 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Mike Looijmans <mike.looijmans@...ic.nl>, linux-iio@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Michael.Hennerich@...log.com,
        jic23@...nel.org, knaack.h@....de, pmeerw@...erw.net
Subject: Re: [PATCH v2] iio:ad5064: Add support for ltc2633 and similar
 devices

On 05/08/2017 09:26 AM, Mike Looijmans wrote:
> The Linear Technology LTC2631, LTC2633 and LTC2635 are very similar
> to the AD5064 device, in particular the LTC2627.
> 
> This patch adds support for those devices. Only the LTC2633 has been
> tested, which is the 2-channel variant. The LTC2631 is the 1-channel,
> and the LTC2635 the 4-channel version. The actual DAC resolution depends
> on the exact chip type and can be 12, 10 or 8 bits, using the upper bits
> so this has no effect on the register map. The internal reference is set
> to 2.5V on "L" versions, and it's 4.096V for "H" versions.
> 
> Datasheets:
>     LTC2631: http://www.linear.com/docs/26553
>     LTC2633: http://www.linear.com/docs/39529
>     LTC2635: http://www.linear.com/docs/28754
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>

Reviewed-by: Lars-Peter Clausen <lars@...afoo.de>

Thanks for reworking the patch.