linux-kernel - Re: [PATCH] iommu/rockchip: Remove build dependency on ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2219350.J3uHR7SeXA@diego>
Date:   Wed, 10 May 2017 12:37:56 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dianders@...omium.org, tfiga@...omium.org, seanpaul@...omium.org,
        zyw@...k-chips.com, mark.yao@...k-chips.com,
        iommu@...ts.linux-foundation.org, Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] iommu/rockchip: Remove build dependency on ARM

Hi Jeffy,

Am Mittwoch, 10. Mai 2017, 18:28:12 CEST schrieb Jeffy Chen:
> This patch removes the build dependency on ARM, so we can build on arm64
> as well.
> 
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> ---
> 
>  drivers/iommu/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index 6ee3a25..cb26f45 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -219,7 +219,6 @@ config OMAP_IOMMU_DEBUG
> 
>  config ROCKCHIP_IOMMU
>  	bool "Rockchip IOMMU Support"
> -	depends on ARM

The previous patch from Simon Xue that was delayed due to the drm
changes needed did a
	depends in ARM || ARM64
instead.

I'm not sure which variant is better and Rockchip is currently not
providing any other cpu architectures, just noting the difference and
letting you and Joerg decide which one to choose :-) .

Enabling the iommu on arm64 looks good to me in any case.


Heiko



>  	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	select IOMMU_API
>  	select ARM_DMA_USE_IOMMU