lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 May 2017 13:34:18 +0200 From: Matthias Brugger <matthias.bgg@...il.com> To: Shailendra Verma <shailendra.v@...sung.com>, John Crispin <blogic@...nwrt.org>, Henry Chen <henryc.chen@...iatek.com>, Daniel Kurtz <djkurtz@...omium.org>, Arnd Bergmann <arnd@...db.de>, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, p.shailesh@...sung.com, ashish.kalra@...sung.com, Shailendra Verma <shailendra.capricorn@...il.com> Subject: Re: [PATCH] Soc: mediatek - Fix possible NULL derefrence. On 27/01/17 12:17, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma <shailendra.v@...sung.com> I fixed the subject line and queued it for v4.12-next/soc Sorry for the (huge) delay. Matthias > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index a5f1093..c48db98 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1117,6 +1117,11 @@ static int pwrap_probe(struct platform_device *pdev) > const struct of_device_id *of_slave_id = NULL; > struct resource *res; > > + if (!of_id) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > + > if (pdev->dev.of_node->child) > of_slave_id = of_match_node(of_slave_match_tbl, > pdev->dev.of_node->child); >
Powered by blists - more mailing lists