linux-kernel - Re: [PATCH] drm/prime: include device.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170510144807.GJ7978@nuc-i3427.alporthouse.com>
Date:   Wed, 10 May 2017 15:48:07 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] drm/prime: include device.h

On Wed, May 10, 2017 at 07:40:01AM -0700, Laura Abbott wrote:
> Explictly add linux/device.h to ensure struct device is defined:
> 
> In file included from include/drm/drm_file.h:38:0,
>                  from drivers/gpu/drm/drm_file.c:38:
> include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside
> 	  parameter list will not be visible outside of this definition or
> 	  declaration
>           struct device *attach_dev);

We aren't using it for anything other than an opaque pointer, so a
struct device;
forward decl will suffice?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre