linux-kernel - Re: [PATCHv2] drm/prime: Forward declare struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO_48GEDs4UxWnSjfYw1yk1j2Rfo3rwJMV1631nhOR1w86QGQQ@mail.gmail.com>
Date:   Wed, 10 May 2017 22:43:03 +0530
From:   Sumit Semwal <sumit.semwal@...aro.org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Intel Graphics Development <intel-gfx@...ts.freedesktop.org>
Subject: Re: [PATCHv2] drm/prime: Forward declare struct device

Hi Laura,

On 10 May 2017 at 22:35, Laura Abbott <labbott@...hat.com> wrote:
>
> We need a declaration of struct device to avoid warnings:
>
> In file included from include/drm/drm_file.h:38:0,
>                  from drivers/gpu/drm/drm_file.c:38:
> include/drm/drm_prime.h:71:14: warning: 'struct device' declared inside
>           parameter list will not be visible outside of this definition or
>           declaration
>           struct device *attach_dev);
>                  ^~~~~~
>
> Forward declare it.
>
> Signed-off-by: Laura Abbott <labbott@...hat.com>
Thanks for the patch; feel free to add my
Reviewed-by: Sumit Semwal <sumit.semwal@...aro.org>

> ---
> v2: Switch to foward declaration instead of including a header.
> ---
>  include/drm/drm_prime.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index 46fd1fb..59ccab4 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -50,6 +50,8 @@ struct drm_prime_file_private {
>         struct rb_root handles;
>  };
>
> +struct device;
> +
>  struct dma_buf_export_info;
>  struct dma_buf;
>
> --
> 2.7.4
>

Best,
Sumit.