linux-kernel - Re: [PATCH] gpio: aspeed: Don't attempt to debounce if disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZwf2feNGCn6RNOXK82PeMXmxJ1MBL=0aBajLHTZ_WP_Q@mail.gmail.com>
Date:   Thu, 11 May 2017 13:32:20 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Joel Stanley <joel@....id.au>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Jeffery <andrew@...id.au>
Subject: Re: [PATCH] gpio: aspeed: Don't attempt to debounce if disabled

On Tue, May 2, 2017 at 8:08 AM, Joel Stanley <joel@....id.au> wrote:

> We warn the user at driver probe time that debouncing is disabled.
> However, if they request debouncing later on we print a confusing error
> message:
>
>  gpio_aspeed 1e780000.gpio: Failed to convert 5000us to cycles at 0Hz: -524
>
> Instead bail out when the clock is not present.
>
> Fixes: 5ae4cb94b3133 (gpio: aspeed: Add debounce support)
> Signed-off-by: Joel Stanley <joel@....id.au>

Patch applied for fixes.

Yours,
Linus Walleij