linux-kernel - Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 May 2017 16:32:24 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Luis Oliveira <Luis.Oliveira@...opsys.com>, wsa@...-dreams.de,
        robh+dt@...nel.org, mark.rutland@....com,
        mika.westerberg@...ux.intel.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Ramiro.Oliveira@...opsys.com, Joao.Pinto@...opsys.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

On Thu, 2017-05-11 at 16:20 +0300, Jarkko Nikula wrote:
> On 05/08/2017 07:53 PM, Andy Shevchenko wrote:
> > > +	} else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) {
> > 
> > GENMASK(15, 0)
> > 
> 
> I don't think this increase readability compared to 0x0000ffff here.

If it's a defined constant it might do, otherwise I'm fine with explicit
value.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy