linux-kernel - Re: Lockdep splat involving all_q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10e33da8-316d-9f51-b608-91ff7c68e2fa@kernel.dk>
Date:   Wed, 10 May 2017 20:55:54 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     paulmck@...ux.vnet.ibm.com, peterz@...radead.org
Cc:     linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        tglx@...utronix.de
Subject: Re: Lockdep splat involving all_q_mutex

On 05/10/2017 04:34 PM, Paul E. McKenney wrote:
> Hello!
> 
> I got the lockdep splat shown below during some rcutorture testing (which
> does CPU hotplug operations) on mainline at commit dc9edaab90de ("Merge
> tag 'acpi-extra-4.12-rc1' of git://git.kernel.org/.../rafael/linux-pm").
> My kneejerk reaction was just to reverse the "mutex_lock(&all_q_mutex);"
> and "get_online_cpus();" in blk_mq_init_allocated_queue(), but then
> I noticed that commit eabe06595d62 ("block/mq: Cure cpu hotplug lock
> inversion") just got done moving these two statements in the other
> direction.

The problem is that that patch got merged too early, as it only
fixes a lockdep splat with the cpu hotplug rework. Fix is coming Linus'
way, it's in my for-linus tree.

-- 
Jens Axboe