linux-kernel - Re: [PATCH] ata: avoid gcc-7 warning in ata_timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170511145009.GB30473@htj.duckdns.org>
Date:   Thu, 11 May 2017 10:50:09 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Adam Manzanares <adam.manzanares@....com>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: avoid gcc-7 warning in ata_timing_quantize

Hello, Arnd.

On Thu, May 11, 2017 at 02:51:25PM +0200, Arnd Bergmann wrote:
> gcc-7 warns about the result of a constant multiplication used as
> a boolean:
> 
> drivers/ata/libata-core.c: In function 'ata_timing_quantize':
> drivers/ata/libata-core.c:3164:30: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
> 
> This slightly rearranges the macro to simplify the code and avoid
> the warning at the same time.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Heh, that's an interesting new warning.  Appied to
libata/for-4.12-fixes.

Thanks.

-- 
tejun