linux-kernel - Re: [PATCH] xfs: avoid harmless gcc-7 warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a31impdu8_i6TNjfnPwj-Pv=dy2P=-LW=4xt6-8Aw+4Ag@mail.gmail.com>
Date:   Thu, 11 May 2017 16:56:41 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        linux-xfs@...r.kernel.org, Dave Chinner <dchinner@...hat.com>,
        Brian Foster <bfoster@...hat.com>,
        Eric Sandeen <sandeen@...hat.com>,
        Calvin Owens <calvinowens@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfs: avoid harmless gcc-7 warnings

On Thu, May 11, 2017 at 4:02 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Thu, May 11, 2017 at 02:49:21PM +0200, Arnd Bergmann wrote:
>> gcc-7 flags the use of integer math inside of a condition
>> as a potential bug:
>>
>> fs/xfs/xfs_bmap_util.c: In function 'xfs_swap_extents_check_format':
>> fs/xfs/xfs_bmap_util.c:1619:8: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
>> fs/xfs/xfs_bmap_util.c:1629:8: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
>>
>> This one is clearly fine, and we can add a comparison to zero
>> to shut up the warning.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  fs/xfs/xfs_bmap_util.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
>> index 2b954308a1d6..cbd3ffe42f39 100644
>> --- a/fs/xfs/xfs_bmap_util.c
>> +++ b/fs/xfs/xfs_bmap_util.c
>> @@ -1613,7 +1613,7 @@ xfs_swap_extents_check_format(
>>        * extent format...
>>        */
>>       if (tip->i_d.di_format == XFS_DINODE_FMT_BTREE) {
>> -             if (XFS_IFORK_BOFF(ip) &&
>> +             if ((XFS_IFORK_BOFF(ip) != 0) &&
>
> Even if we were fine with fixing this odd warning the additional braces
> are simply bogus.

The warning seems generally useful and is enabled by default in gcc-7.
An example of a real bug it found is
https://patchwork.kernel.org/patch/9431813/, so I'd prefer to leave it
enabled and fix the few instances in the kernel.

I found a better way to rework the code to avoid the warning, sending
out v2 now.

    Arnd