linux-kernel - Re: [PATCH 1/4] vmbus: Improve a size determination in vmbus_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170511093056.036d93b6@xeon-e3>
Date:   Thu, 11 May 2017 09:30:56 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     devel@...uxdriverproject.org,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] vmbus: Improve a size determination in
 vmbus_device_create()

On Thu, 11 May 2017 18:15:46 +0200
SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 11 May 2017 17:30:10 +0200
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/hv/vmbus_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 0087b49095eb..6802d74f162c 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -1145,5 +1145,5 @@ struct hv_device *vmbus_device_create(const uuid_le *type,
>  {
>  	struct hv_device *child_device_obj;
>  
> -	child_device_obj = kzalloc(sizeof(struct hv_device), GFP_KERNEL);
> +	child_device_obj = kzalloc(sizeof(*child_device_obj), GFP_KERNEL);
>  	if (!child_device_obj) {

This looks fine.

Acked-by: Stephen Hemminger <stephen@...workplumber.org>