linux-kernel - Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170511172119.GA23588@roeck-us.net>
Date:   Thu, 11 May 2017 10:21:19 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Guru Das Srinagesh <gurooodas@...il.com>
Cc:     heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
        yueyao@...gle.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types

On Wed, May 10, 2017 at 10:51:35PM -0700, Guru Das Srinagesh wrote:
> Fix the following sparse warnings about incorrect type usage:
> 
> fusb302.c:1028:32: warning: incorrect type in argument 1 (different base types)
> fusb302.c:1028:32:    expected unsigned short [unsigned] [usertype] header
> fusb302.c:1028:32:    got restricted __le16 const [usertype] header
> fusb302.c:1484:32: warning: incorrect type in argument 1 (different base types)
> fusb302.c:1484:32:    expected unsigned short [unsigned] [usertype] header
> fusb302.c:1484:32:    got restricted __le16 [usertype] header
> 
> Signed-off-by: Guru Das Srinagesh <gurooodas@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/staging/typec/fusb302/fusb302.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index 2cee9a9..3bec9d5 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1025,7 +1025,7 @@ static int fusb302_pd_send_message(struct fusb302_chip *chip,
>  	buf[pos++] = FUSB302_TKN_SYNC1;
>  	buf[pos++] = FUSB302_TKN_SYNC2;
>  
> -	len = pd_header_cnt(msg->header) * 4;
> +	len = pd_header_cnt_le(msg->header) * 4;
>  	/* plug 2 for header */
>  	len += 2;
>  	if (len > 0x1F) {
> @@ -1481,7 +1481,7 @@ static int fusb302_pd_read_message(struct fusb302_chip *chip,
>  				     (u8 *)&msg->header);
>  	if (ret < 0)
>  		return ret;
> -	len = pd_header_cnt(msg->header) * 4;
> +	len = pd_header_cnt_le(msg->header) * 4;
>  	/* add 4 to length to include the CRC */
>  	if (len > PD_MAX_PAYLOAD * 4) {
>  		fusb302_log(chip, "PD message too long %d", len);
> -- 
> 2.7.4
>