linux-kernel - Re: [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170511181416.e3esc3rhuemw6p5q@earth>
Date:   Thu, 11 May 2017 20:14:16 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andy Gross <andy.gross@...aro.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Loic Poulain <loic.poulain@...el.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4

Hi Arnd,

On Thu, May 11, 2017 at 02:11:26PM +0200, Arnd Bergmann wrote:
> Like the other H4 variants, this only builds when the base
> H4 support is enabled, otherwise we get a build error:
> 
> drivers/bluetooth/hci_nokia.c:624:33: error: array type has incomplete element type 'struct h4_recv_pkt'
> 
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This has already been sent by Tobias Regnery some days ago:

http://www.spinics.net/lists/linux-bluetooth/msg70433.html

-- Sebastian

>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 40994d96d151..b2cf0ae6b62d 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
>  	depends on BT_HCIUART
>  	depends on BT_HCIUART_SERDEV
>  	depends on PM
> +	select BT_HCIUART_H4
>  	help
>  	  Nokia H4+ is serial protocol for communication between Bluetooth
>  	  device and host. This protocol is required for Bluetooth devices
> -- 
> 2.9.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)