linux-kernel - Re: [PATCH] smp_call_function: use inline helpers instead of macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201705120203.cTLhRlNy%fengguang.wu@intel.com>
Date:   Fri, 12 May 2017 02:53:48 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild-all@...org, Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] smp_call_function: use inline helpers instead of macros

Hi Arnd,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.11 next-20170511]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Arnd-Bergmann/smp_call_function-use-inline-helpers-instead-of-macros/20170512-004338
config: mips-ip32_defconfig (attached as .config)
compiler: mips64-linux-gnuabi64-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All errors (new ones prefixed by >>):

   arch/mips/mm/c-r4k.c: In function 'r4k_on_each_cpu':
>> arch/mips/mm/c-r4k.c:101:27: error: 'cpu_foreign_map' undeclared (first use in this function)
      smp_call_function_many(&cpu_foreign_map[smp_processor_id()],
                              ^~~~~~~~~~~~~~~
   arch/mips/mm/c-r4k.c:101:27: note: each undeclared identifier is reported only once for each function it appears in

vim +/cpu_foreign_map +101 arch/mips/mm/c-r4k.c

d374d9374 James Hogan  2016-07-13   85  }
d374d9374 James Hogan  2016-07-13   86  
d374d9374 James Hogan  2016-07-13   87  /*
7f3f1d01a Ralf Baechle 2006-05-12   88   * Special Variant of smp_call_function for use by cache functions:
7f3f1d01a Ralf Baechle 2006-05-12   89   *
7f3f1d01a Ralf Baechle 2006-05-12   90   *  o No return value
7f3f1d01a Ralf Baechle 2006-05-12   91   *  o collapses to normal function call on UP kernels
7f3f1d01a Ralf Baechle 2006-05-12   92   *  o collapses to normal function call on systems with a single shared
7f3f1d01a Ralf Baechle 2006-05-12   93   *    primary cache.
c8c5f3fd9 Ralf Baechle 2010-10-29   94   *  o doesn't disable interrupts on the local CPU
7f3f1d01a Ralf Baechle 2006-05-12   95   */
d374d9374 James Hogan  2016-07-13   96  static inline void r4k_on_each_cpu(unsigned int type,
d374d9374 James Hogan  2016-07-13   97  				   void (*func)(void *info), void *info)
7f3f1d01a Ralf Baechle 2006-05-12   98  {
7f3f1d01a Ralf Baechle 2006-05-12   99  	preempt_disable();
d374d9374 James Hogan  2016-07-13  100  	if (r4k_op_needs_ipi(type))
640511ae9 James Hogan  2016-07-13 @101  		smp_call_function_many(&cpu_foreign_map[smp_processor_id()],
640511ae9 James Hogan  2016-07-13  102  				       func, info, 1);
7f3f1d01a Ralf Baechle 2006-05-12  103  	func(info);
7f3f1d01a Ralf Baechle 2006-05-12  104  	preempt_enable();
7f3f1d01a Ralf Baechle 2006-05-12  105  }
7f3f1d01a Ralf Baechle 2006-05-12  106  
ec74e361f Ralf Baechle 2005-07-13  107  /*
ec74e361f Ralf Baechle 2005-07-13  108   * Must die.
ec74e361f Ralf Baechle 2005-07-13  109   */

:::::: The code at line 101 was first introduced by commit
:::::: 640511ae92466800c75da77a3c7f72b8488c93a1 MIPS: c-r4k: Exclude sibling CPUs in SMP calls

:::::: TO: James Hogan <james.hogan@...tec.com>
:::::: CC: Ralf Baechle <ralf@...ux-mips.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (14423 bytes)