linux-kernel - Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdziFXdN6an9XdNtL_kAOu_iBtDqu7n26EY0wkR6mkDKA@mail.gmail.com>
Date:   Thu, 11 May 2017 22:02:41 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Anatolij Gustschin <agust@...x.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] gpiolib: Add stubs for gpiod lookup table interface

On Thu, May 11, 2017 at 9:24 PM, Anatolij Gustschin <agust@...x.de> wrote:
> Add stubs for gpiod_add_lookup_table() and gpiod_remove_lookup_table()
> for the !GPIOLIB case to prevent build errors.
>

Thanks!

FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

It will fix this kbuild bot complain: https://lkml.org/lkml/2017/4/2/209

> Signed-off-by: Anatolij Gustschin <agust@...x.de>
> ---
> Changes in v4:
>  - move stubs to gpio/machine.h
>
> Changes in v3:
>  - add stubs for !GPIOLIB case. Drop prototypes, these are
>    already in gpio/machine.h
>
> Changes in v2:
>  - move gpiod_lookup_table out of #ifdef
>
>  include/linux/gpio/machine.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h
> index c0d712d..f738d50 100644
> --- a/include/linux/gpio/machine.h
> +++ b/include/linux/gpio/machine.h
> @@ -56,7 +56,14 @@ struct gpiod_lookup_table {
>         .flags = _flags,                                                  \
>  }
>
> +#ifdef CONFIG_GPIOLIB
>  void gpiod_add_lookup_table(struct gpiod_lookup_table *table);
>  void gpiod_remove_lookup_table(struct gpiod_lookup_table *table);
> +#else
> +static inline
> +void gpiod_add_lookup_table(struct gpiod_lookup_table *table) {}
> +static inline
> +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) {}
> +#endif
>
>  #endif /* __LINUX_GPIO_MACHINE_H */
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko