linux-kernel - Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 May 2017 21:15:59 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Eric Anholt <eric@...olt.net>
Cc:     dri-devel@...ts.freedesktop.org,
        Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        CK Hu <ck.hu@...iatek.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Yannick Fertre <yannick.fertre@...com>,
        Philippe Cornu <philippe.cornu@...com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup
 func.

On Thu, 11 May 2017 11:31:27 -0700
Eric Anholt <eric@...olt.net> wrote:

> drm_encoder_cleanup() finishes with memsetting it to 0, already.
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

> ---
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> index 65a3bd7a0c00..4b2cfbd0d43f 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> @@ -83,14 +83,8 @@ static const struct drm_encoder_helper_funcs atmel_hlcdc_panel_encoder_helper_fu
>  	.enable = atmel_hlcdc_rgb_encoder_enable,
>  };
>  
> -static void atmel_hlcdc_rgb_encoder_destroy(struct drm_encoder *encoder)
> -{
> -	drm_encoder_cleanup(encoder);
> -	memset(encoder, 0, sizeof(*encoder));
> -}
> -
>  static const struct drm_encoder_funcs atmel_hlcdc_panel_encoder_funcs = {
> -	.destroy = atmel_hlcdc_rgb_encoder_destroy,
> +	.destroy = drm_encoder_cleanup,
>  };
>  
>  static int atmel_hlcdc_panel_get_modes(struct drm_connector *connector)