linux-kernel - Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170511195047.qw7tf4c42evqszhq@hirez.programming.kicks-ass.net>
Date:   Thu, 11 May 2017 21:50:47 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Juri Lelli <juri.lelli@....com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Luca Abeni <luca.abeni@...tannapisa.it>,
        Daniel Bristot de Oliveira <bristot@...hat.com>
Subject: Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing
 throttle and yielded

On Thu, May 11, 2017 at 03:01:16PM +0100, Juri Lelli wrote:

> > -	if (dl_se->dl_yielded)
> > -		dl_se->dl_yielded = 0;
> > -	if (dl_se->dl_throttled)
> > -		dl_se->dl_throttled = 0;
> > +	dl_se->dl_yielded = 0;
> > +	dl_se->dl_throttled = 0;
> >  }
> 
> Looks good to me.
> 
> Peter, any particular reason why you wanted to first check the values?

No idea, could be general paranoia on unconditional writes or something.