linux-kernel - Re: [PATCH] FS: Fixing return type of unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAExDi1SJbkuabX7j1Fe6wO3k=3VS8iswXq-MjtWidM5=YkStYg@mail.gmail.com>
Date:   Thu, 11 May 2017 22:09:19 +0200
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Pushkar Jambhlekar <pushkar.iit@...il.com>,
        Joe Perches <joe@...ches.com>, linux-fsdevel@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux-Sparse <linux-sparse@...r.kernel.org>
Subject: Re: [PATCH] FS: Fixing return type of unsigned_offsets

On Thu, May 11, 2017 at 8:07 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> FVO"needed" equal to "needed to make sparse STFU"?  If anything, that's
> sparse being wrong - evaluate.c:check_assignment_type() should do
>                 if (t == &ctype_bool) {
>                         if (is_fouled_type(s))
>                                 warning((*rp)->pos, "%s degrades to integer",
>                                         show_typename(s->ctype.base_type));
>                         goto Cast;
>                 }
> right after
>                 } else if (!(sclass & TYPE_RESTRICT))
>                         goto Cast;

What about an explicit cast of restricted types to bool?
I think we would want the equivalent of this patch for those too.

-- Luc