linux-kernel - Re: [PATCH v2] sound: Disable the build of OSS drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2e30dfe-78a2-2d9f-5b0c-e60188a018bb@infradead.org>
Date:   Thu, 11 May 2017 16:50:36 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Linus Torvalds <torvalds@...uxfoundation.org>
Subject: Re: [PATCH v2] sound: Disable the build of OSS drivers

On 05/11/17 13:58, Takashi Iwai wrote:
> OSS drivers are left as badly unmaintained, and now we're facing a
> problem to clean up the hackish set_fs() usage in their codes.  Since
> most of drivers have been covered by ALSA, and the others are dead old
> and inactive, let's leave them RIP.
> 
> This patch is the first step: disable the build of OSS drivers.
> We'll eventually drop the whole codes and clean up later.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Tested-by: Randy Dunlap <rdunlap@...radead.org>


> ---
> 
> v1->v2: Smaller changes, as Linus and Randy suggested.
> 	The first dmasound Kconfig inclusion is still commented out since
> 	it's shorter/simpler in the end.
> 
>  sound/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/Kconfig b/sound/Kconfig
> index ee2e69a9ecd1..de23fc39cec8 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -54,7 +54,7 @@ config SOUND_OSS_CORE_PRECLAIM
>  
>  	  If unsure, say Y.
>  
> -source "sound/oss/dmasound/Kconfig"
> +# source "sound/oss/dmasound/Kconfig"
>  
>  if !M68K && !UML
>  
> @@ -115,6 +115,7 @@ endif # SND
>  menuconfig SOUND_PRIME
>  	tristate "Open Sound System (DEPRECATED)"
>  	select SOUND_OSS_CORE
> +	depends on BROKEN
>  	help
>  	  Say 'Y' or 'M' to enable Open Sound System drivers.
>  
> 


-- 
~Randy