linux-kernel - Re: [PATCH 1/2] KVM: nVMX: fix EPT permissions as reported in exit qualification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c89d7f5-b806-4bd8-e4cb-60e946ee7822@gmail.com>
Date:   Fri, 12 May 2017 13:13:07 +0800
From:   Xiao Guangrong <guangrong.xiao@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     Peter Feiner <pfeiner@...gle.com>,
        David Matlack <dmatlack@...gle.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Xiao Guangrong <xiaoguangrong@...cent.com>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH 1/2] KVM: nVMX: fix EPT permissions as reported in exit
 qualification



On 05/12/2017 11:59 AM, Xiao Guangrong wrote:
error:
>> @@ -452,7 +459,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
>>        */
>>       if (!(errcode & PFERR_RSVD_MASK)) {
>>           vcpu->arch.exit_qualification &= 0x187;
>> -        vcpu->arch.exit_qualification |= ((pt_access & pte) & 0x7) << 3;
>                                                                  ^ here, the original code
> is buggy as pt_access and pte have different bit order, fortunately, this patch fixes it
> too. :)
> 

It's exactly what this patch aims at, do not know what i was thinking when
wrote these down. :(