lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 12 May 2017 10:01:09 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Christoph Hellwig <hch@....de>, Jaroslav Kysela <perex@...ex.cz>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Linux/m68k" <linux-m68k@...r.kernel.org>
Subject: Re: [alsa-devel] future of sounds/oss

On Fri, 12 May 2017 09:30:04 +0200,
Geert Uytterhoeven wrote:
> 
> Hi Iwai-san,
> 
> On Fri, May 12, 2017 at 9:27 AM, Takashi Iwai <tiwai@...e.de> wrote:
> > On Fri, 12 May 2017 09:17:35 +0200,
> > Geert Uytterhoeven wrote:
> >> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@...e.de> wrote:
> >> > On Fri, 12 May 2017 09:03:07 +0200,
> >> > Geert Uytterhoeven wrote:
> >> >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@...e.de> wrote:
> >> >> > index ee2e69a9ecd1..41eda578d08e 100644
> >> >> > --- a/sound/Kconfig
> >> >> > +++ b/sound/Kconfig
> >> >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
> >> >> >
> >> >> >           If unsure, say Y.
> >> >> >
> >> >> > -source "sound/oss/dmasound/Kconfig"
> >> >> > +### TO-BE-REMOVED
> >> >> > +# source "sound/oss/dmasound/Kconfig"
> >> >>
> >> >> Please note the dmasound drivers do not have ALSA equivalents.
> >> >
> >> > These belong to the latter, "dead old and inactive" ones :)
> >> >
> >> > Are these driver still used with the latest kernel?  If users are
> >>
> >> I believe so.
> >>
> >> > willing to help, we can provide the port to ALSA drivers, too.
> >>
> >> That would be great, thanks!
> >
> > OK, we can go forward, then.
> >
> > But, looking at the tree again, I noticed that ALSA isn't built yet at
> > all for m68k.  I don't remember why it's disabled.
> > Jaroslav, do you know the reason behind it?
> 
> Because ALSA doesn't have any drivers that can be used on m68k platforms?

But we have virtual and generic drivers (such as UART support), so
there seems no reason to stop it.  Maybe the lack of proper MMU
support was the reason?  Let's try to cross-build...

> > And, dmasound is a completely different implementation from the other
> > OSS, thus it doesn't suffer from set_fs() hack.  That is, we may still
> > keep dmasound, while removing other OSS stuff.
> 
> That's indeed good to know.
> 
> > Meanwhile we'll try to support ALSA on m64k and eventually target to
> > drop dmasound stuff.
> >
> > Does it sound more feasible?
> 
> Yes, definitely in the short run ;-)

OK, below is the revised patch.  Now it's a really one-liner.


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@...e.de>
Subject: [PATCH v3] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a
problem to clean up the hackish set_fs() usage in their codes.  Since
most of drivers have been covered by ALSA, and the others are dead old
and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers.
We'll eventually drop the whole codes and clean up later.

Note that sound/oss/dmasound is still kept, since it's a completely
different implementation of OSS, and it doesn't suffer from set_fs()
hack.  Moreover, the build of ALSA is disabled on M68K by some reason,
thus disabling it shall result in a regression.  This one will be
disabled / removed once when we add the support in ALSA side.

Tested-by: Randy Dunlap <rdunlap@...radead.org>
Signed-off-by: Takashi Iwai <tiwai@...e.de>
---

v1->v2: Smaller changes, as Linus and Randy suggested.
	The first dmasound Kconfig inclusion is still commented out since
	it's shorter/simpler in the end.
v2->v3: Keep dmasound, as it's independent from other OSS
	implementations.

 sound/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/Kconfig b/sound/Kconfig
index ee2e69a9ecd1..6a215a8c0490 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -115,6 +115,7 @@ endif # SND
 menuconfig SOUND_PRIME
 	tristate "Open Sound System (DEPRECATED)"
 	select SOUND_OSS_CORE
+	depends on BROKEN
 	help
 	  Say 'Y' or 'M' to enable Open Sound System drivers.
 
-- 
2.12.2

Powered by blists - more mailing lists