linux-kernel - Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170512081209.2xvq7gtvl54dxl6b@dell>
Date:   Fri, 12 May 2017 09:12:09 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jan Kiszka <jan.kiszka@...mens.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: intel_quark_i2c_gpio: Add support for SIMATIC
 IOT2000 platform

On Tue, 09 May 2017, Andy Shevchenko wrote:

> On Tue, 2017-05-09 at 06:40 +0200, Jan Kiszka wrote:
> > The SIMATIC IOT2000 is derived from the Galileo Gen2 board and shares
> > its I2C frequency.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> 
> > Signed-off-by: Sascha Weisenberger <sascha.weisenberger@...mens.com>
> 
> Hmm... I thought that SoB chain goes from first author to last. (Or in
> case of maintainer / submitter their SoB goes at the end, which is
> apparently not the case here).

Yes, that's correct.  I will switch them when I apply the patch.

> Other than above
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> > 
> > ---
> >  drivers/mfd/intel_quark_i2c_gpio.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mfd/intel_quark_i2c_gpio.c
> > b/drivers/mfd/intel_quark_i2c_gpio.c
> > index 7946d6e38b87..98dddf2831ad 100644
> > --- a/drivers/mfd/intel_quark_i2c_gpio.c
> > +++ b/drivers/mfd/intel_quark_i2c_gpio.c
> > @@ -72,6 +72,10 @@ static const struct i2c_mode_info
> > platform_i2c_mode_info[] = {
> >  		.name = "GalileoGen2",
> >  		.i2c_scl_freq = 400000,
> >  	},
> > +	{
> > +		.name = "SIMATIC IOT2000",
> > +		.i2c_scl_freq = 400000,
> > +	},
> >  	{}
> >  };
> >  
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog