linux-kernel - Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170511.214233.1981021610793266657.davem@davemloft.net>
Date:   Thu, 11 May 2017 21:42:33 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     pavel.belous@...antia.com, vomlehn@...as.net,
        Alexander.Loktionov@...antia.com, Dmitry.Bezrukov@...antia.com,
        Dmitrii.Tarakanov@...antia.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on
 error status

From: Colin King <colin.king@...onical.com>
Date: Thu, 11 May 2017 19:29:40 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> The error status err is initialized as zero and then being checked
> several times to see if it is less than zero even when it has not
> been updated.  It may seem that the err should be assigned to the
> return code of the call to the various *offload_en_set calls and
> then we check for failure, however, these functions are void and
> never actually return any status.  
> 
> Since these error checks are redundant we can remove these
> as well as err and the error exit label err_exit.
> 
> Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically
> dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thank you.