linux-kernel - Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170512090741.GC26599@kroah.com>
Date:   Fri, 12 May 2017 11:07:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     suniel.spartan@...il.com
Cc:     devel@...verdev.osuosl.org, sunil.m@...hveda.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported
 by sparse

On Tue, May 09, 2017 at 03:17:56PM +0530, suniel.spartan@...il.com wrote:
> From: Suniel Mahesh <suniel.spartan@...il.com>
> 
> The function Mk16_le() is calling le16_to_cpu()
> internally. le16_to_cpu() takes an argument of type (__le *)
> but the argument passed is of type (u16 *). Fixed it by passing
> the correct argument type.
> 
> Signed-off-by: Suniel Mahesh <suniel.spartan@...il.com>
> ---
>  .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c      | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

Is this a resend?

> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> index 5039172..11ddf30 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
> @@ -172,7 +172,7 @@ static inline u16 Mk16(u8 hi, u8 lo)
>  }
>  
>  
> -static inline u16 Mk16_le(u16 *v)
> +static inline u16 Mk16_le(__le16 *v)
>  {
>  	return le16_to_cpu(*v);
>  }

Just use the real function here and delete this "odd" one.

thanks,

greg k-h